Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Greenhouse: certify to GA #17239

Merged
merged 5 commits into from
Sep 28, 2022
Merged

Source Greenhouse: certify to GA #17239

merged 5 commits into from
Sep 28, 2022

Conversation

davydov-d
Copy link
Collaborator

What

Certify Greenhouse connector as generally available

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Sep 27, 2022
@davydov-d davydov-d linked an issue Sep 27, 2022 that may be closed by this pull request
[EPIC] Source Greenhouse to GA #16061
Closed
11 tasks
@davydov-d
Copy link
Collaborator Author

davydov-d commented Sep 27, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-greenhouse

🕑 connectors/source-greenhouse https://github.com/airbytehq/airbyte/actions/runs/3135186444
✅ connectors/source-greenhouse https://github.com/airbytehq/airbyte/actions/runs/3135186444
Python tests coverage:

Name                              Stmts   Miss  Cover
-----------------------------------------------------
source_greenhouse/source.py           4      0   100%
source_greenhouse/__init__.py         2      0   100%
source_greenhouse/components.py      68      5    93%
-----------------------------------------------------
TOTAL                                74      5    93%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       152     26    83%   21-23, 29-31, 36-43, 48-61, 239, 250-258
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-67, 70-72, 75-77, 80-82, 85-87, 90-92, 95-113, 147-149
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1358    466    66%

Build Passed

Test summary info:

All Passed

@davydov-d davydov-d temporarily deployed to more-secrets September 27, 2022 11:24 Inactive
@lazebnyi lazebnyi requested review from lazebnyi and removed request for roman-yermilov-gl September 27, 2022 11:30
@davydov-d
Copy link
Collaborator Author

davydov-d commented Sep 27, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-greenhouse

🕑 connectors/source-greenhouse https://github.com/airbytehq/airbyte/actions/runs/3136119386
❌ connectors/source-greenhouse https://github.com/airbytehq/airbyte/actions/runs/3136119386
🐛 https://gradle.com/s/ceyjfnd5q46ac

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contai...
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
FAILED test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
=================== 5 failed, 36 passed in 80.31s (0:01:20) ====================

@davydov-d davydov-d temporarily deployed to more-secrets September 27, 2022 13:46 Inactive
@davydov-d
Copy link
Collaborator Author

davydov-d commented Sep 28, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-greenhouse

🕑 connectors/source-greenhouse https://github.com/airbytehq/airbyte/actions/runs/3141635616
✅ connectors/source-greenhouse https://github.com/airbytehq/airbyte/actions/runs/3141635616
Python tests coverage:

Name                              Stmts   Miss  Cover
-----------------------------------------------------
source_greenhouse/source.py           4      0   100%
source_greenhouse/__init__.py         2      0   100%
source_greenhouse/components.py      68      5    93%
-----------------------------------------------------
TOTAL                                74      5    93%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       152     26    83%   21-23, 29-31, 36-43, 48-61, 239, 250-258
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-67, 70-72, 75-77, 80-82, 85-87, 90-92, 95-113, 147-149
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1358    466    66%

Build Passed

Test summary info:

All Passed

@davydov-d davydov-d temporarily deployed to more-secrets September 28, 2022 07:34 Inactive
@davydov-d
Copy link
Collaborator Author

davydov-d commented Sep 28, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-greenhouse

🕑 Publishing the following connectors:
connectors/source-greenhouse
https://github.com/airbytehq/airbyte/actions/runs/3141751910


Connector Did it publish? Were definitions generated?
connectors/source-greenhouse ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@davydov-d davydov-d merged commit 3f99a22 into master Sep 28, 2022
@davydov-d davydov-d deleted the ddavydov/#16061-source-greenhouse-to-ga branch September 28, 2022 08:19
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Sep 28, 2022
Merged
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
@davydov-d @octavia-squidington-iii @robbinhan
Source Greenhouse: certify to GA (airbytehq#17239)
d534706 
* airbytehq#16061 source GA: certify to GA

* source greenhouse: upd changelog

* airbytehq#16061 source greenhouse: do not fail when encounter 403 error, skip instead

* airbytehq#16061 retry 429

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <[email protected]>
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@davydov-d @octavia-squidington-iii @jhammarstedt
Source Greenhouse: certify to GA (airbytehq#17239)
608f146 
* airbytehq#16061 source GA: certify to GA

* source greenhouse: upd changelog

* airbytehq#16061 source greenhouse: do not fail when encounter 403 error, skip instead

* airbytehq#16061 retry 429

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bazarnov bazarnov bazarnov approved these changes

@lazebnyi lazebnyi lazebnyi approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/greenhouse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[EPIC] Source Greenhouse to GA
4 participants
@davydov-d @bazarnov @lazebnyi @octavia-squidington-iii